Add method for returning serialized attributes after dynamic updates #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if dialog_field.dynamic? | ||
| dynamic_values = dialog_field.trigger_automate_value_updates | ||
| extra_attributes.merge!("values" => dynamic_values) |
There was a problem hiding this comment.
extra_attributes["values"] = dynamic_values - has the same effect, but shorter and faster
|
Hi @eclarizio, I think this is good. For a while I thought we needed the checked_value parameter for the new method as per refresh_json_value for drop down list and radio button, but those values are set in the dialog by the API via dialog_fields, so I think we're ok. |
eclarizio
force-pushed
the
update_and_serialize_dialog_fields_method
branch
from
a15bf1c
to
1f950ab
Compare
|
Checked commits eclarizio/manageiq@33e0335~...1f950ab with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 spec/models/dialog_field_serializer_spec.rb
|
gmcculloug
added a commit
that referenced
this pull request
Jan 14, 2016
…ields_method Add method for returning serialized attributes after dynamic updates
h-kataria
pushed a commit
to h-kataria/manageiq
that referenced
this pull request
Jan 15, 2016
MR for PR6097 - Add method for returning serialized attributes after dynamic updates This MR adds a method that will be used by the API in order to return all attributes of a dynamic dialog field (after it has run through its respective automate method). Cherry-pick was clean aside from the `dialog_field_serializer_spec` which I changed to use stubs instead of "allow" since this branch isn't on the latest Rspec yet. PR: ManageIQ#6097 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1297953 See merge request !715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abellotti This should do the trick for replacing
refresh_json_values, I think. Let me know if you have any feedback.