Restrict users and groups in 'set ownership' screens #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo please review |
lpichler
force-pushed
the
fix_users_and_groups_in_set_ownership
branch
from
3ea1165
to
8c883cf
Compare
…hip' screens Groups: For admin all groups otherwise only groups to which he belongs Users: For admin all users otherwise only users from groups to which he belongs
lpichler
force-pushed
the
fix_users_and_groups_in_set_ownership
branch
from
8c883cf
to
d0c1afc
Compare
|
Checked commits lpichler/manageiq@30bf895~...d0c1afc with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
@lpichler This looks good. Was there a BZ or github issue for this? |
|
No, I found this issue during the other BZ, should I create BZ for it ? |
gtanzillo
added a commit
that referenced
this pull request
Feb 2, 2016
…nership Restrict users and groups in 'set ownership' screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example: Infrastructure->VM->detail of any VM, then in toolbar Configuration->Set ownership
Restriction:
Groups: For admin all groups otherwise only groups to which he belongs and nontenant groups.
Users: For admin all users otherwise only users from groups to which he belongs
Slightly affect #6260 for admin user, but according the BZ, request was for 'normal users' so I think that it is OK.