http_proxy support for authenticating to Azure #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djberg96 @blomquisg - please review. |
| @@ -32,11 +32,14 @@ def description | |||
| ManageIQ::Providers::Azure::Regions.find_by_name(provider_region)[:description] | |||
| end | |||
|
|
|||
| def self.raw_connect(clientid, clientkey, azuretenantid) | |||
| def self.raw_connect(clientid, clientkey, azuretenantid, proxy_uri = nil) | |||
There was a problem hiding this comment.
Can we change the parameter names to be standard snake case for better readability?
clientid to client_id
clientkey to client_key
azuretenantid to azure_tenant_id
|
Checked commits bronaghs/manageiq@9391564~...82e7450 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@chessbyte - funny, I have never noticed that before. Please review. Thanks. |
|
👍 |
|
@chessbyte @blomquisg - Can this be merged? |
chessbyte
added a commit
that referenced
this pull request
Mar 9, 2016
http_proxy support for authenticating to Azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy connection information is set in vmdb.tmpl.yml and read by the Azure CloudManager::raw_connect method.
https://bugzilla.redhat.com/show_bug.cgi?id=1314835