Generate ChargeBack report by Tenant

[aljesusg]

After have assignment to tenant #7202 we need make a chargeback report by tenant.

Description

This pull request provides a chargeback report by tenant

Now we can show costs by Tenant

And select the tenant that we wanna get the report

### Working with

@lpichler

More Information

Taiga:
https://tree.taiga.io/project/sergioocon-charging-in-manageiq/task/40

[aljesusg]

@miq-bot add-label wip
@miq-bot add-label chargeback
@miq-bot add-label reporting

[aljesusg]

@miq-bot add-label wip

[aljesusg]

@miq-bot remove-label wip

[lpichler]

@aljesusg can you move this huge condition (and if it is possible change it somehow for better readibility) to a method valid_chargeback_fields
then we can get here

elsif @edit[:new][:model] == "Chargeback" && !valid_chargeback_fields
     add_flash..
     ....

what do you think ?

[aljesusg]

Ok @lpichler It's fine. I am working on it. I have 2 proposal that you can check here https://tree.taiga.io/project/sergioocon-charging-in-manageiq/task/40 but Rubocop throw a complexity errors :(

  # Check if chargeback field is valid
  VALID_SHOW_TYP_FIELDS = %w(owner tenant tag).freeze
  def valid_chargeback_fields
    if @edit[:new][:cb_show_typ] && VALID_SHOW_TYP_FIELDS.include?(@edit[:new][:cb_show_typ])
      case @edit[:new][:cb_show_typ]
      when "owner"
        return true if @edit[:new][:cb_owner_id]
      when "tenant"
        return true if @edit[:new][:cb_tenant_id]
      when "tag"
        return true if @edit[:new][:cb_tag_cat] && @edit[:new][:cb_tag_value]
      end
    end
    false
  end

  # Check if chargeback field is valid
  VALID_SHOW_TYP_FIELDS = %w(owner tenant tag).freeze
  def valid_chargeback_fields
    if @edit[:new][:cb_show_typ] && VALID_SHOW_TYP_FIELDS.include?(@edit[:new][:cb_show_typ])
      case @edit[:new][:cb_show_typ]
      when "owner" then return true if @edit[:new][:cb_owner_id]
      when "tenant" then return true if @edit[:new][:cb_tenant_id]
      when "tag" then return true if @edit[:new][:cb_tag_cat] && @edit[:new][:cb_tag_value]
      end
    end
    false
  end

[lpichler]

@aljesusg yes, much better - I am for 1.,and I am suggesting also something like this:

 # Check if chargeback field is valid
  def valid_chargeback_fields
    is_valid = false
    if %w(owner tenant tag).include?(@edit[:new][:cb_show_typ]) 
      is_valid = case @edit[:new][:cb_show_typ]
                       when "owner"  then @edit[:new][:cb_owner_id]
                       when "tenant" then @edit[:new][:cb_tenant_id]
                       when "tag"    then @edit[:new][:cb_tag_cat] && @edit[:new][:cb_tag_value]
    end
    is_valid
  end

inspired by https://github.com/bbatsov/ruby-style-guide and find on this page When assigning the result of a conditional expression to a variable

maybe this will rubocop accept :)

[lpichler]

@aljesusg I was able to save report when "Show costs by tenant" was selected(= 'Tenant') but "Tenant" select box was unselected (= 'choose tenant')
so can you validate also this case?
it seems that change need to be done in this method:
https://github.com/aljesusg/manageiq/blob/generate_report_on_tenant/app/controllers/report_controller/reports.rb#L223

[lpichler]

@aljesusg

I was looking into db how it is stored: from MiqReport#db_options:

---
:rpt_type: chargeback
:options:
  :interval: daily
  :interval_size: 1
  :end_interval_offset: 1
  :tenant: '10000000000002'

so there will be :tenant_id instead of :tenant and can be tenant_id stored as integer ? so maybe it will be better to have:

---
:rpt_type: chargeback
:options:
  :interval: daily
  :interval_size: 1
  :end_interval_offset: 1
  :tenant_id: 10000000000002

Do you agree ?

[lpichler]

@aljesusg otherwise looks good to me !

It will be also nice to write spec for generating report to ensure if it considers only VMs which belongs to any tenant or basically test method build_results_for_report_chargeback

@gtanzillo can you review it also, please ?

[gtanzillo]

@aljesusg Looks good if you make the changes @lpichler suggested, especially adding a test for the report.

[miq-bot]

Checked commits aljesusg/manageiq@38a1214~...53650dd with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 0 offenses detected
Everything looks good. 🍪

[aljesusg]

Done !!!
Thanks @lpichler & @gtanzillo

[aljesusg]

Thanks @lpichler , @gtanzillo & @chessbyte