Split up type overloading of instance_store_* properties for EC2 #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems op_controller/common_spec.rb has sporadic failures :( |
|
Seems good to me. :-) |
Add ebs_only boolean key to MiqEc2InstanceTypes. Fixes ManageIQ#741
Fryguy
force-pushed
the
split_up_ec2_ebs_setting
branch
from
42dc963
to
4a7815a
Compare
|
Rebased now that #746 is merged, so hopefully this goes green now. |
|
Checked commit Fryguy@4a7815a with rubocop 0.21.0 |
|
@Fryguy |
Fryguy
added a commit
that referenced
this pull request
Sep 30, 2014
Split up type overloading of instance_store_* properties for EC2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ebs_only boolean key to MiqEc2InstanceTypes.
Fixes #741
@tenderlove @mkanoor Please review.