UI for orderable orchestration templates

[mzazrivec]

Implemented:

• don't display non-orderable orchestration templates in orch. templates catalogs view
• new read-only screen showing stack's orchestration template + spec
• new button to make a template orderable + spec
• new button to copy a template as orderable + spec
• button to take the user from the stack's orch. template page to the orch. template view in catalog controller

Fixes: #6600

https://bugzilla.redhat.com/show_bug.cgi?id=1302810

[mzazrivec]

@bzwei @h-kataria @martinpovolny Review?

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[h-kataria]

@bzwei can you try this in UI, tested in my environment LGTM.

[h-kataria]

@mzazrivec i think we don't need this check anymore, we do want to show a link for both types of Orchestartion Templates from Stack summary screen,

[bzwei]

@mzazrivec from the stack summary page I don't see the template appears in the Relationships table when the template is not orderable. So I cannot test the feature to convert or copy to orderable.

[h-kataria]

@bzwei once @mzazrivec removes the check on #7822 (diff), it should show links to both orderable & non-orderable templates.

[mzazrivec]

@bzwei @h-kataria I removed the check preventing from displaying non-orderable
template in UI.

Regarding the new screen -- the requirements, as they were described in the ticket -- were mentioning
a new screen for both orderable & non-orderable templates. There's a button to take you to
the template in catalog explorer. Plus, after you create a copy of a template, you'll be also taken
to catalog explorer to the newly created template.

[h-kataria]

@bzwei please re-test

[bzwei]

@mzazrivec
Tested the copy as orderable feature. It does not create a new template, instead the old template got renamed and orderable flag set to true. With this feature a new template is expected, leaving the existing one untouched.

Tested the make template orderable feature. I saw message "Orchestration Template is now orderable". But the configuration menu does not change. It still looks as if the template is not orderable. Even worse the template got deleted from the database. I am doing some debugging too to see whether this is a backend problem.

[bzwei]

@mzazrivec I confirmed there is a backend bug causing the template being deleted. Please do not merge this PR until the backend issue is cleared. At the mean time please take a look at the other problems that I reported.

[h-kataria]

marking it WIP until back end issue is fixed.

[mzazrivec]

@bzwei So what probably happened with the OT copy you described above was that a new template (the copy) was created and the old one was deleted.

[bzwei]

@mzazrivec no, I verified from database that the stack still referenced to the old template but it got renamed and flagged.

[mzazrivec]

@bzwei That's strange, because this is the controller code doing the copy:

ot = OrchestrationTemplate.new(
  :name        => params[:templateName],
  :description => params[:templateDescription],
  :type        => original_template.type,
  :content     => params[:templateContent],
  :draft       => params[:templateDraft] == "true",
)
begin
  ot.save_as_orderable!
rescue StandardError => bang
  ...
else
  ...
end

I'm not sure how this can create the results you're describing.

[bzwei]

@mzazrivec then it must be caused by the same backend bug. I am able to create a PR. Will update here.

[bzwei]

@mzazrivec I understand the problem now. For a copied template, if the user modifies the content before save, a new template will be generated. If the user only renames, all the changes (name and orderable flag) will be applied to the existing template. This is according to design. So this is not a real problem. The reasoning behind it is we don't allow two templates to have the same content.

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[mzazrivec]

@bzwei I fixed the problem with re-rendering the screen after making a non-orderable template orderable.

[bzwei]

@mzazrivec The problem still exists. After the template gets converted to orderable, the view in a catalog menu is gray out, and the other two menus are enabled. Also I suggested change the text to View this Orchestration Template in Catalogs because Catalogs is a valid tab under Services.

[mzazrivec]

@bzwei Fixed.

[miq-bot]

Checked commits mzazrivec/manageiq@cf577d3~...43639e1 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
15 files checked, 32 offenses detected

app/controllers/orchestration_stack_controller.rb

• 🔹 - Line 176, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for make_ot_orderable is too high. [31.32/15]
• 🔹 - Line 202, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for orchestration_template_copy is too high. [17.06/15]
• 🔹 - Line 227, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for stacks_ot_copy_submit is too high. [52.31/15]
• 🔹 - Line 227, Col 3 - Metrics/MethodLength - Method has too many lines. [36/25]

app/helpers/application_helper/toolbar/stack_orchestration_template_center.rb

• 🔶 - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• 🔶 - Line 29, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/views/orchestration_stack/_copy_orchestration_template.html.haml

• 🔴 Warn - Line 10, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 10, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 10, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 10, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 10, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 20, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 20, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 20, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 20, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 29, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 29, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 29, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 36, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 36, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 36, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 36, Col - - Operator => should be surrounded by a single space.

app/views/orchestration_stack/_stack_orchestration_template.html.haml

• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 9, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 32, Col - - Operator => should be surrounded by a single space.
• 🔴 Warn - Line 32, Col - - Operator => should be surrounded by a single space.

spec/factories/orchestration_stack.rb

• 🔹 - Line 9, Col 121 - Metrics/LineLength - Line is too long. [153/120]
• 🔹 - Line 16, Col 121 - Metrics/LineLength - Line is too long. [176/120]

[bzwei]

Tested and looks good now. 👍