Fix Sat6 subscription organization handling #7893
Conversation
This was preventing correctly saving the organization name, which prevented any one from subscribing to updates from Sat6. Created a new form key which stores the organization display name. https://bugzilla.redhat.com/show_bug.cgi?id=1301607
|
Checked commit carbonin@2251116 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 app/views/ops/_settings_rhn_edit_tab.html.haml
|
|
Adding some screenshots. The difference can be seen in the organization name. Before: After: |
| else | ||
| @edit[:new][:customer_org] = nil unless @edit[:organizations].include?(@edit[:new][:customer_org]) | ||
| @edit[:new][:customer_org] = nil unless @edit[:organizations].key?(@edit[:new][:customer_org_display]) |
There was a problem hiding this comment.
What sets customer_org_display in this branch?
There was a problem hiding this comment.
It gets pulled from the @edit[:organizations] hash either way on save here, so I guess setting it in the if block is useless, but might look better than ignoring that part of the @edit[:organizations].first array
There was a problem hiding this comment.
So this is saying "Set customer_org to nil unless the current org came back in the organizations list", meaning we are editing, which means it would get pulled from the database.
There was a problem hiding this comment.
I guess the short answer is if it was set, it came from the database here.
This was preventing correctly saving the organization name,
which prevented any one from subscribing to updates from Sat6.
Created a new form key which stores the organization display name.
https://bugzilla.redhat.com/show_bug.cgi?id=1301607
@Fryguy @h-kataria please review