Fixed an undefined method `start_with?' for nil:NilClass #7936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
h-kataria
force-pushed
the
catalog_item_editor_fix
branch
from
5bc633a
to
1786361
Compare
| @@ -0,0 +1,13 @@ | |||
| describe "catalog/_form.html.haml" do | |||
| before(:each) do | |||
There was a problem hiding this comment.
(:each) is the default and thus you don't need to specify it (minor, so I won't let it hold up the merge)
st_prov_type is nil when adding a Catalog Bundle, st_prov_type is only on the initial screen when user selects type of Catalog Item they want to add. Issue was introduced in commit 2c95dd5
h-kataria
force-pushed
the
catalog_item_editor_fix
branch
from
1786361
to
1b731e6
Compare
|
Checked commit h-kataria@1b731e6 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@dclarizio @martinpovolny please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
st_prov_type is nil when adding a Catalog Bundle, st_prov_type is only on the initial screen when user selects type of Catalog Item they want to add.
Issue was introduced in commit 2c95dd5
@bzwei please review.