Moved call to get_node_info into import specific methods. #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@h-kataria can you try to write a test to catch this kind of error in the future? Thx, Dan |
h-kataria
force-pushed
the
automate_customization_form_fix
branch
2 times, most recently
from
6818b73
to
53ceb6c
Compare
|
@dclarizio added spec test. |
Adding call to get_node_info in replace_right_cell was causing it to be called twice once from specific methods and once from replace_right_cell, this was also causing issues when going to add/edit screens in Buttons accordion. Issue was introduced in commit 46032b2 Fixes ManageIQ#8195
h-kataria
force-pushed
the
automate_customization_form_fix
branch
from
53ceb6c
to
7a40f34
Compare
|
Checked commit h-kataria@7a40f34 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Apr 25, 2016
Moved call to get_node_info into import specific methods. (cherry picked from commit 6a21ea8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding call to get_node_info in replace_right_cell was causing it to be called twice once from specific methods and once from replace_right_cell, this was also causing issues when going to add/edit screens in Buttons accordion. Issue was introduced in commit 46032b2
Fixes #8195
@mkanoor please test
@dclarizio please review.
before:
after:
