[api] VM power operations are not queued properly #8225
Conversation
When queueing VM power or smartstate operations, the zone was not getting specified for the queue so in environments with providers in different zones, those providers were not getting the task to perform on those VMs. This fixes: ManageIQ#7998 https://bugzilla.redhat.com/show_bug.cgi?id=1326955
|
@gtanzillo @imtayadeway please review. |
|
Checked commit abellotti@7b76cc4 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
| :method_name => "start", | ||
| :zone => zone.name).count).to eq(1) | ||
| end | ||
|
|
There was a problem hiding this comment.
@abellotti Do you think we need to test the case where the request comes in to an appliance in one zone but should be queued in a different zone? Not really sure how necessary that test is because in either case the message should be queued to the zone of the object and this test does that. So I'll leave it up to you.
There was a problem hiding this comment.
unless we're testing the my_zone method, I don't think it's necessary, without the fix, this test fails (zone is not added in the queue). here the zone obtained is from the vm/instance my_zone (which is the my_zone of the vm's ems), and in the test case, the api_zone of the ems in the api test env.
[api] VM power operations are not queued properly (cherry picked from commit f495df9)
When queueing VM power or smartstate operations, the zone was not getting
specified for the queue so in environments with providers in different zones,
those providers were not getting the task to perform on those VMs.
This fixes: #7998
https://bugzilla.redhat.com/show_bug.cgi?id=1326955