Role RBAC tree and feature fixes #8281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria : can you take a look, please? I am trying to write some specs for these changes. |
|
Fix verified in UI. Looks good. |
|
Now that #8291 is merged, closed/reopened to restart Travis |
|
Restarted travis, all is green now. |
|
@martinpovolny looks like Travis did not finish running. |
|
Travis was green from last night until I pushed the specs in #8312. Strange. |
Add default value for the 2nd argument so that it's not the caller's resposibility to pass the correct value.
Extract recurse_sections_and_features from rbac_role_get_form_vars deduplicating the logic in recurse_sections_and_features and adding support for nested menu sections.
martinpovolny
force-pushed
the
role_rbac_fixes
branch
from
62b03cc
to
010dd5a
Compare
|
Checked commits martinpovolny/manageiq@ccef8fc~...010dd5a with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/ops_controller/ops_rbac.rb
|
|
@martinpovolny @h-kataria @dclarizio is this for |
|
@chessbyte added yes, not a blocker, but really needed for setting RBAC features in roles |
chessbyte
pushed a commit
that referenced
this pull request
Apr 28, 2016
Role RBAC tree and feature fixes (cherry picked from commit 91b798c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Role RBAC tree editor work: