Enforce that name and ems_id be present to submit AuthKeyPair creation form
#8357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't enable the Add button unless at least a name and ems_id have been entered in the form. The key field remains optional. This was not being enforced before, allowing invalid form submissions.
|
Checked commit mansam@85d8d92 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@dclarizio @h-kataria @martinpovolny please review |
|
@dclarizio @martinpovolny |
chessbyte
pushed a commit
that referenced
this pull request
May 2, 2016
…elds Enforce that `name` and `ems_id` be present to submit AuthKeyPair creation form (cherry picked from commit 98e0379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't enable the Add button unless at least a name and ems_id
have been entered in the form. The key field remains optional.
This was not being enforced before, allowing invalid form
submissions.
cc @durandom https://bugzilla.redhat.com/show_bug.cgi?id=1329427