Fix tag assignment for datastores when invoked from the provider list

[lgalis]

https://bugzilla.redhat.com/show_bug.cgi?id=1333257

[lgalis]

@miq-bot add_label ui, bug, wip

[lgalis]

@miq-bot remove_label wip

[lgalis]

@dclarizio - please review

[dclarizio]

Fix verified in UI . . . can merge when tests have completed.

[miq-bot]

Checked commits lgalis/manageiq@05b4689~...3326333 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
7 files checked, 13 offenses detected

app/controllers/application_controller/tags.rb

• 🔶 - Line 24, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.

app/controllers/storage_controller.rb

• 🔶 - Line 507, Col 37 - Style/SpaceAroundOperators - Surrounding space missing for operator &&.

spec/controllers/ems_infra_controller_spec.rb

• 🔴 Warn - Line 280, Col 7 - Lint/UselessAssignment - Useless assignment to variable - breadcrumbs.
• 🔶 - Line 281, Col 45 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 282, Col 45 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 283, Col 45 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 284, Col 45 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 285, Col 50 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 285, Col 74 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 286, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• 🔹 - Line 278, Col 121 - Metrics/LineLength - Line is too long. [156/120]

spec/controllers/storage_controller_spec.rb

• 🔶 - Line 152, Col 9 - Style/ClosingParenthesisIndentation - Align ) with (.
• 🔶 - Line 156, Col 9 - Style/ClosingParenthesisIndentation - Align ) with (.

[dclarizio]

@lgalis there is a failing test in VMDB suite that I haven't seen before. Seems unrelated, but can you please verify?

[lgalis]

Verified the failure was unrelated - test was re-run.

[dclarizio]

Replication and azure test failures are unrelated to this PR, merging.