Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Forest Entries box when switching mode back to LDAP/LDAPS #8658

Merged

Conversation

h-kataria
Copy link
Contributor

  • Fixed code to show Forest Entries box when switching back to LDAP/LDAPS mode
  • Added spec test to verify fix
  • Fixed alignment of icons in Forest Entries box

https://bugzilla.redhat.com/show_bug.cgi?id=1326499

@dclarizio please review

screenshot for minor alignment fix that is also part of this PR.
before
image_misalignment

after
alignment_fix

- Fixed code to show Forest Entries box when switching back to LDAP/LDAPS mode
- Added spec test to verify fix
- Fixed alignment of icons in Forest Entries box

https://bugzilla.redhat.com/show_bug.cgi?id=1326499
@h-kataria h-kataria force-pushed the ldap_forest_entries_display_fix branch from 0d9df8b to 4e40366 Compare May 12, 2016 16:40
@miq-bot
Copy link
Member

miq-bot commented May 12, 2016

Checked commit h-kataria@4e40366 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 0 offenses detected
Everything looks good. ⭐

@dclarizio dclarizio merged commit 6568a95 into ManageIQ:master May 12, 2016
@dclarizio dclarizio deleted the ldap_forest_entries_display_fix branch May 12, 2016 18:16
@dclarizio dclarizio added this to the Sprint 41 Ending May 30, 2016 milestone May 12, 2016
chessbyte pushed a commit that referenced this pull request May 12, 2016
Display Forest Entries box when switching mode back to LDAP/LDAPS
(cherry picked from commit 6568a95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants