Check for EMS existence before stopping event monitor #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -578,6 +578,11 @@ def stop_event_monitor | |||
| end | |||
|
|
|||
| def stop_event_monitor_queue | |||
| unless id | |||
There was a problem hiding this comment.
ah, I see, I don't have these checks in openstack/manager_mixin, which is overwriting those methods. Ok, let me fix that
Check for EMS new_record before stopping event monitor Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1336859
Ladas
force-pushed
the
check_for_ems_existence_before_stopping_event_monitor
branch
from
e89d0da
to
4065040
Compare
|
Checked commit Ladas@4065040 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 app/models/manageiq/providers/openstack/manager_mixin.rb
|
chessbyte
pushed a commit
that referenced
this pull request
May 25, 2016
…opping_event_monitor Check for EMS existence before stopping event monitor (cherry picked from commit 0f46d9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for EMS existence before stopping event monitor
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1336859