Fixed code to start spinner when selecting values in drop down. #8823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
fix_for_spinners_in_pull_downs
branch
from
086400a
to
101192a
Compare
h-kataria
changed the title
h-kataria
force-pushed
the
fix_for_spinners_in_pull_downs
branch
from
2810adf
to
101192a
Compare
- Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
- Added spec tests to verify fix
https://bugzilla.redhat.com/show_bug.cgi?id=1337475
h-kataria
force-pushed
the
fix_for_spinners_in_pull_downs
branch
from
101192a
to
2a127d1
Compare
h-kataria
changed the title
|
@dclarizio @himdel ready for review. With this fix it should work if data-miq_sparkle_on/'data-miq_sparkle_off attributes were set for a drop down and also if beforeSend/complete were passed in as options to miqSelectPickerEvent function call. We should cleanup the code to go with setting these single way, otherwise iti gets confusing and leads to errors. |
|
Checked commit h-kataria@2a127d1 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
This PR should be merged once #8828 is fixed. |
chessbyte
pushed a commit
that referenced
this pull request
May 20, 2016
Fixed code to start spinner when selecting values in drop down. (cherry picked from commit a951789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1337475
@dclarizio @himdel please review.
This code confusion started in commit a628815 in https://github.com/ManageIQ/manageiq/pull/8316 where changes were instroduced to turn spinner on/off based upon$(this).attr('data-miq_sparkle_on')/$ (this).attr('data-miq_sparkle_off') this code was further refactored/changed in latest commits assuming that spinner should be turned on/off solely based upon $(this).attr('data-miq_sparkle_on')/$ (this).attr('data-miq_sparkle_off').