New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delayed translation of ui constants #9086
Delayed translation of ui constants #9086
Conversation
d97509e
to
c1d35f5
Compare
/cc @h-kataria |
812ae86
to
8292cf9
Compare
This change is to make sure the block given is evaluated at the same moment when we're calling .call() or .translate(), not when we're constructing the object.
8292cf9
to
5326cdf
Compare
These constants are loaded at application startup and therefore need to be translated when the constants are being used.
5326cdf
to
91be50d
Compare
Checked commits mzazrivec/manageiq@c67cddf~...91be50d with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/ops_controller/settings/analysis_profiles.rb
app/views/chargeback/_cb_assignments.html.haml
app/views/miq_policy/_alert_profile_assign.html.haml
spec/lib/postponed_translation_spec.rb
|
This should go to Darga, after a detailed review. |
@martinpovolny Review please? |
Needs to be backported together with #9268 |
…stants Delayed translation of ui constants (cherry picked from commit e04182e)
Changes:
the block given is evaluated at the same moment when we're calling
.call()
or.translate()
,not when we're constructing the object.
therefore need to be translated when the constants are being used.
Not all constants have been addressed, the rest will be addressed in a later PR.
https://bugzilla.redhat.com/show_bug.cgi?id=1340437
https://bugzilla.redhat.com/show_bug.cgi?id=1340426
https://bugzilla.redhat.com/show_bug.cgi?id=1275614
https://bugzilla.redhat.com/show_bug.cgi?id=1233072