Don't run a rake task from the host_storages migration #9178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo @Fryguy please review |
|
LGTM 👍 @carbonin This prevents upgrades as well, right? (and thus should be marked a blocker?) |
|
Correct @Fryguy |
This migration was created to fix some issues associated with adding and assigning a primary key when replication is enabled. `prepare_replication_without_sync` attempts to retrieve the replication worker settings; which as of ManageIQ#7432, requires the `settings_changes` table be present. This command will now fail because that table is added in a later migration. Removing this command will not cause an issue as rubyrep accounts for all unconfigured tables at first startup. We could also require running `rake evm:dbsync:prepare_replication_without_sync` after migration during upgrades. https://bugzilla.redhat.com/show_bug.cgi?id=1344112
carbonin
force-pushed
the
dont_run_rake_from_migrations
branch
from
78a2813
to
9debfda
Compare
chessbyte
pushed a commit
that referenced
this pull request
Jun 11, 2016
Don't run a rake task from the host_storages migration (cherry picked from commit fc421ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration was created to fix some issues associated with adding and assigning a primary key to the
host_storagestable when replication is enabled.prepare_replication_without_syncattempts to retrieve the replication worker settings; which as of #7432, requires thesettings_changestable be present. This command will now fail because that table is added in a later migration.Removing this command will not cause an issue as rubyrep accounts for all unconfigured tables at first startup. We could also require running
rake evm:dbsync:prepare_replication_without_syncafter migration during upgrades.https://bugzilla.redhat.com/show_bug.cgi?id=1344112