Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Apply button states on Import/Import Tags forms #9261

Merged
merged 3 commits into from Jun 17, 2016

Conversation

bmclaughlin
Copy link
Contributor

Apply button now remains disabled until valid files are uploaded in both the Settings - Import Tags and Settings - Import forms.

https://bugzilla.redhat.com/show_bug.cgi?id=1224428

@bmclaughlin
Copy link
Contributor Author

@miq-bot add-label ui, bug

@bmclaughlin
Copy link
Contributor Author

@dclarizio, @h-kataria please review

@h-kataria h-kataria added the wip label Jun 17, 2016
@h-kataria h-kataria changed the title Correct Apply button states on Import/Import Tags forms [WIP] - Correct Apply button states on Import/Import Tags forms Jun 17, 2016
@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2016

Checked commits bmclaughlin/manageiq@5510547~...a143c1b with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 2 offenses detected

spec/controllers/ops_controller_spec.rb

@bmclaughlin bmclaughlin changed the title [WIP] - Correct Apply button states on Import/Import Tags forms Correct Apply button states on Import/Import Tags forms Jun 17, 2016
@h-kataria h-kataria removed the wip label Jun 17, 2016
@dclarizio dclarizio merged commit b4afb31 into ManageIQ:master Jun 17, 2016
@dclarizio dclarizio deleted the disable-apply-button branch June 17, 2016 15:08
@dclarizio dclarizio added this to the Sprint 42 Ending June 20, 2016 milestone Jun 17, 2016
chessbyte pushed a commit that referenced this pull request Jul 4, 2016
Correct Apply button states on Import/Import Tags forms
(cherry picked from commit b4afb31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants