Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darga] Upgrade to ovirt 0.11.0 #9725

Closed
wants to merge 1 commit into from
Closed

[Darga] Upgrade to ovirt 0.11.0 #9725

wants to merge 1 commit into from

Conversation

jhernand
Copy link
Contributor

@jhernand jhernand commented Jul 11, 2016

Purpose

This PR updates the oVirt provider to use version 0.11.0 of the ovirt gem, as that is necessary in order to calculate correctly the ems_ref attributes of inventory items retrieved from version 4 of oVirt.

Note that the commit in this PR was already part of another PR merged to the master branch, but that can't (I guess) be back-ported to the darga branch, as it contains other changes shouldn't be back-ported.

Links

This PR is part of the fix for the following bug:

(cherry picked from commit 3a881bc)
@jhernand
Copy link
Contributor Author

jhernand commented Jul 11, 2016

@chessbyte, @bdunne, @Fryguy, I'm not sure how you handle this situation: need to backport part of a PR that has been merged to the master branch. What I did is apply the required patch (cherry-picked the patch that @bdunne created, no change) from that PR, and create a new PR, based on the darga branch. Let me know if this is OK, or if you want to do it different.

Note also that I don't have permissions to add labels, so I can't add darga/yes.

@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2016

Checked commit https://github.com/jhernand/manageiq/commit/a486fd605bdad3977e14564e6606abec253398c8 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍰

@Fryguy Fryguy changed the title Upgrade to ovirt 0.11.0 [Darga] Upgrade to ovirt 0.11.0 Jul 11, 2016
@Fryguy Fryguy removed the darga/yes label Jul 11, 2016
@Fryguy
Copy link
Member

Fryguy commented Jul 11, 2016

@gmcculloug Note that this is a PR direct to darga and should only be merged by @chessbyte

@bdunne
Copy link
Member

bdunne commented Jul 11, 2016

@jhernand I don't think you can bundle without all of the changes included in the original PR. I think we have to mark it as darga/yes.

@chessbyte
Copy link
Member

@jhernand Closing this PR in favor of backporting #9667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants