[DARGA] toolbars i18n fixes #9744

mzazrivec · 2016-07-12T12:01:00Z

i18n toolbar fixes for the darga branch. The PR contains cherry-picks from the following
master pull requests:

(cherry picked from commit 3cc41f8)

(cherry picked from commit f4014a7)

(cherry picked from commit 89e88db)

(cherry picked from commit 686c253)

Reasons: 1. using ui_lookup here means using string interpolations inside a gettext call. 2. easier translation work & better translations in general (declensions, conjugations, etc) (cherry picked from commit d5daf4f)

(cherry picked from commit 1992c40)

(cherry picked from commit 6946eb0)

(cherry picked from commit bc73375)

Fixes: ManageIQ#9603 (cherry picked from commit 3acf00c)

(cherry picked from commit 13a567e)

martinpovolny · 2016-07-12T15:20:49Z

and #8149

Fryguy · 2016-07-12T16:32:07Z

@martinpovolny Are those last few commits cherry-picks, or did you create them just for darga? If the former, can you update the commit message with the (cherry picked from commit SHA) text (or just re-cherry-pick with git cherry-pick -x)

(cherry picked from commit f64d6ba)

(cherry picked from commit 049db83)

(cherry picked from commit 8775de8)

(cherry picked from commit 92ecff9)

(cherry picked from commit a3a4971)

(cherry picked from commit bf1ef6b)

martinpovolny · 2016-07-12T18:22:33Z

@Fryguy : done

miq-bot · 2016-07-12T19:58:41Z

Checked commits mzazrivec/manageiq@9c9d2ef~...e510627 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
76 files checked, 61 offenses detected

app/helpers/application_helper/toolbar/auth_key_pair_cloud_center.rb

❕ - Line 30, Col 121 - Metrics/LineLength - Line is too long. [209/120]

app/helpers/application_helper/toolbar/auth_key_pair_clouds_center.rb

❕ - Line 41, Col 121 - Metrics/LineLength - Line is too long. [212/120]

app/helpers/application_helper/toolbar/condition_center.rb

❕ - Line 40, Col 121 - Metrics/LineLength - Line is too long. [167/120]
❕ - Line 45, Col 121 - Metrics/LineLength - Line is too long. [151/120]
❕ - Line 50, Col 121 - Metrics/LineLength - Line is too long. [200/120]

app/helpers/application_helper/toolbar/conditions_center.rb

❗ - Line 13, Col 29 - Performance/Casecmp - Use casecmp instead of upcase ==.

app/helpers/application_helper/toolbar/container_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [196/120]

app/helpers/application_helper/toolbar/container_group_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [184/120]

app/helpers/application_helper/toolbar/container_groups_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [203/120]

app/helpers/application_helper/toolbar/container_image_registries_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [227/120]

app/helpers/application_helper/toolbar/container_image_registry_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [205/120]

app/helpers/application_helper/toolbar/container_node_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [186/120]

app/helpers/application_helper/toolbar/container_nodes_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [205/120]

app/helpers/application_helper/toolbar/container_project_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [192/120]

app/helpers/application_helper/toolbar/container_projects_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [211/120]

app/helpers/application_helper/toolbar/container_replicator_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [198/120]

app/helpers/application_helper/toolbar/container_replicators_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [217/120]

app/helpers/application_helper/toolbar/container_route_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [188/120]

app/helpers/application_helper/toolbar/container_routes_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [211/120]

app/helpers/application_helper/toolbar/container_service_center.rb

❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [192/120]

app/helpers/application_helper/toolbar/container_services_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [211/120]

app/helpers/application_helper/toolbar/containers_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [215/120]

app/helpers/application_helper/toolbar/ems_cloud_center.rb

❕ - Line 33, Col 121 - Metrics/LineLength - Line is too long. [206/120]

app/helpers/application_helper/toolbar/ems_clouds_center.rb

❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [124/120]
❕ - Line 46, Col 121 - Metrics/LineLength - Line is too long. [225/120]

app/helpers/application_helper/toolbar/ems_container_center.rb

❕ - Line 32, Col 121 - Metrics/LineLength - Line is too long. [216/120]

app/helpers/application_helper/toolbar/ems_containers_center.rb

❕ - Line 39, Col 121 - Metrics/LineLength - Line is too long. [235/120]

app/helpers/application_helper/toolbar/ems_infra_center.rb

❕ - Line 19, Col 121 - Metrics/LineLength - Line is too long. [123/120]
❕ - Line 44, Col 121 - Metrics/LineLength - Line is too long. [224/120]

app/helpers/application_helper/toolbar/ems_infras_center.rb

❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [133/120]
❕ - Line 46, Col 121 - Metrics/LineLength - Line is too long. [243/120]

app/helpers/application_helper/toolbar/ems_middleware_center.rb

❕ - Line 28, Col 121 - Metrics/LineLength - Line is too long. [215/120]

app/helpers/application_helper/toolbar/ems_middlewares_center.rb

❕ - Line 29, Col 121 - Metrics/LineLength - Line is too long. [235/120]

app/helpers/application_helper/toolbar/ems_network_center.rb

❕ - Line 27, Col 121 - Metrics/LineLength - Line is too long. [210/120]

app/helpers/application_helper/toolbar/ems_networks_center.rb

❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [126/120]
❕ - Line 25, Col 121 - Metrics/LineLength - Line is too long. [229/120]

app/helpers/application_helper/toolbar/miq_alert_profiles_center.rb

❕ - Line 13, Col 121 - Metrics/LineLength - Line is too long. [123/120]

app/helpers/application_helper/toolbar/miq_group_center.rb

❕ - Line 35, Col 121 - Metrics/LineLength - Line is too long. [123/120]

app/helpers/application_helper/toolbar/miq_groups_center.rb

❕ - Line 53, Col 121 - Metrics/LineLength - Line is too long. [131/120]

app/helpers/application_helper/toolbar/miq_policies_center.rb

❗ - Line 13, Col 11 - Style/IndentationWidth - Use 2 (not 4) spaces for indentation.

app/helpers/application_helper/toolbar/miq_policy_center.rb

❕ - Line 29, Col 121 - Metrics/LineLength - Line is too long. [130/120]
❕ - Line 42, Col 121 - Metrics/LineLength - Line is too long. [155/120]

app/helpers/application_helper/toolbar/orchestration_stack_center.rb

❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [216/120]

app/helpers/application_helper/toolbar/orchestration_stacks_center.rb

❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [234/120]

app/helpers/application_helper/toolbar/persistent_volume_center.rb

❕ - Line 24, Col 121 - Metrics/LineLength - Line is too long. [190/120]

app/helpers/application_helper/toolbar/persistent_volumes_center.rb

❕ - Line 32, Col 121 - Metrics/LineLength - Line is too long. [209/120]

app/helpers/application_helper/toolbar/storage_center.rb

❕ - Line 22, Col 121 - Metrics/LineLength - Line is too long. [196/120]

app/helpers/application_helper/toolbar/storages_center.rb

❕ - Line 26, Col 121 - Metrics/LineLength - Line is too long. [215/120]

app/helpers/application_helper/toolbar/tenant_center.rb

❕ - Line 52, Col 121 - Metrics/LineLength - Line is too long. [123/120]

app/helpers/application_helper/toolbar/tenants_center.rb

❕ - Line 50, Col 121 - Metrics/LineLength - Line is too long. [131/120]

app/helpers/application_helper/toolbar/user_center.rb

❕ - Line 40, Col 121 - Metrics/LineLength - Line is too long. [121/120]

app/helpers/application_helper/toolbar/users_center.rb

❕ - Line 55, Col 121 - Metrics/LineLength - Line is too long. [130/120]

app/helpers/application_helper/toolbar_builder.rb

❕ - Line 238, Col 121 - Metrics/LineLength - Line is too long. [123/120]

app/helpers/toolbar_helper.rb

❗ - Line 78, Col 9 - Style/ExtraSpacing - Unnecessary spacing detected.

spec/helpers/application_helper/toolbar_builder_spec.rb

❗ - Line 103, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 104, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 108, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 65, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 76, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 77, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 81, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

mzazrivec · 2016-07-13T11:55:22Z

@chessbyte This PR is ready to be tested / merged for Darga (I tested this from developer's POV
and things work correctly).

Martin Povolny and others added 12 commits July 12, 2016 13:25

ExplorerPresenter: use normal Hash instead of HWIA.

9c9d2ef

(cherry picked from commit 3cc41f8)

Toolbar i18n: way to do string interpolation and gettext.

f624103

(cherry picked from commit f4014a7)

User Button#localized instead of direct _().

68d8e2e

(cherry picked from commit 89e88db)

Toolbar i18n: example converted string interpolation.

82576fd

(cherry picked from commit 686c253)

Remove ui_lookup from toolbars

7515b25

Reasons: 1. using ui_lookup here means using string interpolations inside a gettext call. 2. easier translation work & better translations in general (declensions, conjugations, etc) (cherry picked from commit d5daf4f)

ExplorerPresenter no longer uses HWIA; fix spec.

00a0b4d

(cherry picked from commit 1992c40)

Toolbar i18n: fix specs.

79c6e5a

(cherry picked from commit 6946eb0)

ExplorerPresenter: key symbol vs string fix.

cdbf70a

(cherry picked from commit bc73375)

Fix broken strings and i18n in policy toolbar.

4112767

Fixes: ManageIQ#9603 (cherry picked from commit 3acf00c)

Make "truncate" accessible from buttons.

ede3d30

(cherry picked from commit 13a567e)

martinpovolny added darga/yes internationalization labels Jul 12, 2016

martinpovolny mentioned this pull request Jul 12, 2016

[WIP] Darga toolbars i18n fixes #9754

Closed

chessbyte changed the title ~~Darga toolbars i18n fixes~~ [DARGA] toolbars i18n fixes Jul 12, 2016

chessbyte self-assigned this Jul 12, 2016

Martin Povolny added 6 commits July 12, 2016 19:56

Toolbars: use separate key for id and type. Make type a symbol.

9bc657f

(cherry picked from commit f64d6ba)

Toolbars: extract method img_value.

1142f22

(cherry picked from commit 049db83)

Toolbars: extract common keys from toolbar_button.

4d47860

(cherry picked from commit 8775de8)

Toolbars: :enabled is a bool even for custom buttons.

a6d2c60

(cherry picked from commit 92ecff9)

Toolbars: use hash value for hash initialization.

5abfffd

(cherry picked from commit a3a4971)

Toolbars: fixes and spec update.

e510627

(cherry picked from commit bf1ef6b)

martinpovolny force-pushed the darga_toolbars_i18n_fixes branch from 72da89d to e510627 Compare July 12, 2016 18:22

Fryguy removed the darga/yes label Jul 12, 2016

chessbyte merged commit 720a18f into ManageIQ:darga Jul 13, 2016

chessbyte added this to the Sprint 44 Ending Aug 1, 2016 milestone Jul 13, 2016

mzazrivec deleted the darga_toolbars_i18n_fixes branch July 14, 2016 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DARGA] toolbars i18n fixes #9744

[DARGA] toolbars i18n fixes #9744

mzazrivec commented Jul 12, 2016

martinpovolny commented Jul 12, 2016

Fryguy commented Jul 12, 2016 •

edited

martinpovolny commented Jul 12, 2016

miq-bot commented Jul 12, 2016

mzazrivec commented Jul 13, 2016

[DARGA] toolbars i18n fixes #9744

[DARGA] toolbars i18n fixes #9744

Conversation

mzazrivec commented Jul 12, 2016

martinpovolny commented Jul 12, 2016

Fryguy commented Jul 12, 2016 • edited

martinpovolny commented Jul 12, 2016

miq-bot commented Jul 12, 2016

mzazrivec commented Jul 13, 2016

Fryguy commented Jul 12, 2016 •

edited