[DARGA] Backport #9667 Fix gem issues related to rails 5.0 release #9756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chessbyte Please review and label |
Fryguy
changed the title
chessbyte
changed the title
|
Checked commits bdunne/manageiq@549725f~...4927a1b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 gems/pending/util/miq-system.rb
|
|
@bdunne can you review failures on Travis |
|
@chessbyte looks like those failures are caused by 6ff4157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 has a minimum Ruby version of 2.2.2. Several of our gems depend on ActiveSupport. In order to support older Ruby versions in our gems, I've added blank to more_core_extensions and dropped the dependencies on activesupport.
Backport of #9667