Update Guaranteed memory when updating VM's memory #9882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
force-pushed
the
support_decreasing_memory_in_reconfigure_vm
branch
2 times, most recently
from
3ea6845
to
e2338af
Compare
There is a coupling between the Guaranteed memory to the VM memory: Guaranteed cannot exceed the VM memory, and the VM memory cannot be set to a lower value than the guaranteed memory. Therefore the order of updating the vm's memory is considered at update. http://bugzilla.redhat.com/1356193
masayag
force-pushed
the
support_decreasing_memory_in_reconfigure_vm
branch
from
e2338af
to
e8bfbce
Compare
|
Checked commit masayag@e8bfbce with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@borod108 looks good to me. Please review. |
|
Looks good to me according to the current style. Maybe it would be nice to change the "memory = value" to "update_memory_to(value)" some day because it is not obvious that "rhev_vm.memory = value" actually updates the remote object, therefore it looks a bit confusing. But this is not for this PR. In this PR it is nicely explained in the comment which is the best option in my opinion. |
|
@oourfali @blomquisg should this be backported to Darga? |
|
@chessbyte yes please. |
chessbyte
pushed a commit
that referenced
this pull request
Aug 30, 2016
…configure_vm Update Guaranteed memory when updating VM's memory (cherry picked from commit 7270d7d)
|
Darga Backport details: $ git log
commit 4322408030cec7c833292158c99b690b83dec1a7
Author: Greg Blomquist <blomquisg@gmail.com>
Date: Thu Jul 28 13:20:54 2016 -0400
Merge pull request #9882 from masayag/support_decreasing_memory_in_reconfigure_vm
Update Guaranteed memory when updating VM's memory
(cherry picked from commit 7270d7d4036ebdeff94354ec40d7457940c26009) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a coupling between the Guaranteed memory to the VM memory:
Guaranteed cannot exceed the VM memory, and the VM memory cannot
be set to a lower value than the guaranteed memory. Therefore the
order of updating the vm's memory is considered at update.
http://bugzilla.redhat.com/1356193