Fix recursive bot commands #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh i see - this is label specific...I'm concerned this could happen with any command where the bot replies |
Fryguy
reviewed
Feb 22, 2021
Adds a method for fetching the `bot_name` from the `GithubService` module, and standardizes it throughout the codebase.
NickLaMuro
force-pushed
the
fix-bot-recursion-with-add-label
branch
from
99bfe8a
to
c68203d
Compare
NickLaMuro
changed the title
When the bot is issuing command, ignore it so it doesn't try responding to itself.
As an example, when moving an issue, the description could contain the following: "@miq-bot add-label providers/containers, ..." Said label might not exist, so the following could previously be generated: "@miq-bot Cannot apply the following label..." To avoid this with this command specifically, don't include the username in the error message if the bot is the one including it.
NickLaMuro
force-pushed
the
fix-bot-recursion-with-add-label
branch
from
c68203d
to
fb80cc6
Compare
|
First commit trues up our usage of |
|
Checked commits NickLaMuro/miq_bot@e76661e~...fb80cc6 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint lib/github_service/commands/add_label.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bot thinking it is calling itself when making a comment where it's username could be used when adding a label.
See the following for an example:
ManageIQ/manageiq-providers-kubernetes#124 (comment)