Permitted regexp/range support #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
May 20, 2024
| case permitted | ||
| when nil then true | ||
| when Regexp then val.match permitted | ||
| when Range then permitted.to_a.map(&:to_s).include? val |
There was a problem hiding this comment.
This is a shame we can't use .include? directly on the Range. Something we might want to consider in the future somehow.
There was a problem hiding this comment.
iirc I did this b/c of the typing mismatch between the given arg from the cmdline (always a string) and the range type, though maybe it could be compared the other way around?
There was a problem hiding this comment.
Offhand, the way you did it is the only way I can think of, so overall I'm fine to merge. We get strings from the command line so there's really not much we can do about that.
fixed .match to .match? Co-authored-by: Jason Frey <fryguy9@gmail.com>
Fryguy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on the
permitted:feature from @akhoury6 by adding support for ranges and regexp's.It also provides a
permitted_response:to override the error message when the input is does not conform to expectations.Some bugs were fixed for the Array case also (previously did not like integer arrays)
Tests for permitted from parser_test.rb were moved out into a separate file for ease of editing/grouping.
Improves #147
@miq-bot add-label enhancement
@miq-bot add-reviewer @Fryguy @akhoury6