Change CI ruby versions #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gekorob
force-pushed
the
change_ci_ruby_versions
branch
from
20c4e97
to
badb88e
Compare
agrare
reviewed
Mar 19, 2020
.travis.yml
Outdated
| - "2.3.1" | ||
| - ruby-head | ||
| - jruby-head | ||
| - "2.3.8" |
There was a problem hiding this comment.
YAML usually doesn't have a leading space for an array element
There was a problem hiding this comment.
Yeah right, I followed the rules in my local vim linter...
Changing right now
There was a problem hiding this comment.
Ah okay, yeah it looks odd to me I'd expect a leading space as well but 🤷♂️
There was a problem hiding this comment.
No no you're right, I've checked also the yaml spec on the site... I've always to recheck... counterintuitive
|
Checked commit gekorob@badb88e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint **
|
Dropping build for ruby version lesser than 2.3.8
gekorob
force-pushed
the
change_ci_ruby_versions
branch
from
badb88e
to
c61a7e9
Compare
agrare
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping build for ruby version lesser than 2.3.8