Add Ruby 3.3 to test matrix

[Fryguy]

3.3 is actually broken with the following error:

rake aborted!
ArgumentError: wrong number of arguments (given 3, expected 1..2) (ArgumentError)

  USASCIIRegexp = Regexp.new("\\A#{us_ascii}*\\z", nil, 'n')
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/xsd/charset.rb:133:in `initialize'
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/xsd/charset.rb:133:in `new'
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/xsd/charset.rb:133:in `<module:Charset>'
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/xsd/charset.rb:13:in `<module:XSD>'
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/xsd/charset.rb:10:in `<top (required)>'
/Users/jfrey/.gem/ruby/3.3.0/gems/soap4r-ng-2.0.4/lib/wsdl/parser.rb:11:in `<top (required)>'
/Users/jfrey/dev/rbvmomi2/lib/tasks/vmodl_helper.rb:6:in `<top (required)>'
lib/tasks/vmodl.rake:3:in `require_relative'
lib/tasks/vmodl.rake:3:in `<top (required)>'
/Users/jfrey/dev/rbvmomi2/Rakefile:10:in `load'
/Users/jfrey/dev/rbvmomi2/Rakefile:10:in `block in <top (required)>'
/Users/jfrey/dev/rbvmomi2/Rakefile:10:in `each'
/Users/jfrey/dev/rbvmomi2/Rakefile:10:in `<top (required)>'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli/exec.rb:58:in `load'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli/exec.rb:58:in `kernel_load'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli/exec.rb:23:in `run'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli.rb:451:in `exec'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli.rb:34:in `dispatch'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/cli.rb:28:in `start'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/exe/bundle:28:in `block in <top (required)>'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/Users/jfrey/.gem/ruby/3.3.0/gems/bundler-2.5.5/exe/bundle:20:in `<top (required)>'
/Users/jfrey/.rubies/ruby-3.3.0/bin/bundle:25:in `load'
/Users/jfrey/.rubies/ruby-3.3.0/bin/bundle:25:in `<main>'
(See full trace by running task with --trace)

---

From what I can see, soap4r-ng is the problem, however, strangely, I have no idea what it's intention was. See https://github.com/rubyjedi/soap4r/blob/master/lib/xsd/charset.rb#L133. (Aside, note that the README says the gem is unmaintained ☹️).

Looking at the blame it was

• Changed to 'n' for Ruby 1.9 compat: rubyjedi/soap4r@72d438c
• 'NONE' since the first commit 21 years ago: rubyjedi/soap4r@d15647f

---

The interface for Regexp is the following for Ruby 3.2.3 and 3.3.0:

new(string, options = 0, timeout: nil) → regexp
new(regexp, timeout: nil) → regexp 

and is the following for Ruby 3.1.4, 3.0.6, 2.7.8, 2.6.10, and 2.5.9

new(string, [options]) → regexp
new(regexp) → regexp

The code in question is

USASCIIRegexp = Regexp.new("\\A#{us_ascii}*\\z", nil, 'n')

so I have no idea what that 3rd parameter is supposed to be (I assume some older Ruby thing, but I'm having trouble finding docs)

[agrare]

From what I can see, soap4r-ng is the problem, however, strangely, I have no idea what it's intention was. See https://github.com/rubyjedi/soap4r/blob/master/lib/xsd/charset.rb#L133. (Aside, note that the README says the gem is unmaintained ☹️).

This is why I dislike -ng, what do we do now, next-next-gen?

[agrare]

It looks like the third option was "lang" and "N" meant "no encoding ruby/ruby@f65aac7

[agrare]

It looks like the right way to call this now is Regexp.new('foo', Regexp::NOENCODING) per ruby/ruby@7e8fa06

[Fryguy]

Oh great find!

Support for the 3rd argument will be removed after the release of Ruby 3.2.

And that explains why it just started happening with 3.3

[agrare]

rubyjedi/soap4r#27

[micwoj92]

FYI the PR in soap4r got accepted and upstream author said that there will be new version released with this fix included.