Dialogs - call initField from refreshFieldCallback, JSON.parse in set…

…upField only when string

initField needs to be called from refreshFieldCallback so that we don't run the initialization only on initial load, but also on every refresh from server - this makes initial loads and refreshes consistent

setupField should only try to parse json multivalues when not already converted

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693294

src/dialog-user/components/dialog-user/dialogUser.ts

@@ -230,6 +230,8 @@ export class DialogUserController extends DialogClass implements IDialogs {
    */
 
   private refreshFieldCallback(field, data) {
+    this.initField(data);
+
     this.dialogFields[field] = this.updateDialogFieldData(field, data);
 
     this.dialogValues[field] = data.default_value;

src/dialog-user/services/dialogData.ts

@@ -93,7 +93,9 @@ export default class DialogDataService {
       defaultValue = data.default_value ? new Date(data.default_value) : new Date();
     }
 
-    if (data.type === 'DialogFieldDropDownList' && data.options.force_multi_value && data.default_value) {
+    // FIXME maybe better make sure it's never not string (must come from double call)
+    if (data.type === 'DialogFieldDropDownList' && data.options.force_multi_value
+      && data.default_value && _.isString(data.default_value)) {
       defaultValue = JSON.parse(data.default_value);
     }