Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1514196 - Dynamic checkboxes in Dialog component #224

Merged
merged 2 commits into from
Jan 5, 2018

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1514196

@chalettu
Copy link
Contributor Author

checkbox_demo
Demo of fix in action

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2017

Checked commits chalettu/ui-components@4c35a6b~...1f61f3d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny
Copy link
Member

@eclarizio : please, review

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@himdel himdel merged commit ff6fa54 into ManageIQ:master Jan 5, 2018
@himdel himdel added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018
@himdel
Copy link
Contributor

himdel commented Jan 5, 2018

@miq-bot add_label gaprindashvili/backported
@miq-bot remove_label gaprindashvili/yes

This was released in manageiq-ui-components 1.0.4, backported to gaprindashvili via ManageIQ/manageiq-ui-classic#3175 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants