Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the attribute to be edited in the original scope #225

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

romanblanco
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518506

The value edited by bootstrap switch was changed in different scope, so the value of treeSelectorIncludeDomain in the original scope was still set on false.

Making the both-ways binding should fix the issue.

cc/ @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit romanblanco@c2a600f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chessbyte chessbyte changed the title Allow the attribute to be eddited in the original scope Allow the attribute to be edited in the original scope Dec 20, 2017
@dclarizio dclarizio assigned h-kataria and himdel and unassigned h-kataria Dec 20, 2017
@dclarizio dclarizio added the bug label Dec 20, 2017
@karelhala karelhala merged commit 463ca86 into ManageIQ:master Dec 21, 2017
@romanblanco romanblanco deleted the bz1518506 branch December 21, 2017 14:23
@himdel
Copy link
Contributor

himdel commented Jan 5, 2018

@miq-bot add_label gaprindashvili/backported
@miq-bot remove_label gaprindashvili/yes

This was released in manageiq-ui-components 1.0.4, backported to gaprindashvili via ManageIQ/manageiq-ui-classic#3175 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants