Fix assumption that all field.values are objects #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romanblanco : please, review ASAP |
romanblanco
approved these changes
Jan 4, 2018
karelhala
reviewed
Jan 4, 2018
| @@ -48,7 +48,9 @@ export default class DialogEditorService { | |||
| */ | |||
| public getDialogTabs() { | |||
| this.forEachDialogField((field: any) => { | |||
| field.values = field.values.filter(value => value[0] && value[1]); | |||
| if (! _.isEmpty(field.values) && _.isObject(field.values)) { | |||
There was a problem hiding this comment.
Good catch, but better to use _.isArray, since this will take in effect any Object. isEmpty does not need to be there, because filtering over empty array does nothing.
if (field.hasOwnProperty('values') && _.isArray(field.values)) {
field.values = field.values.filter(value => value[0] && value[1]);
}
eclarizio
force-pushed
the
fix_addendum_for_pr223
branch
from
d0071e2
to
e6a183b
Compare
|
Checked commit eclarizio@e6a183b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Thanks @karelhala, fixed. |
|
@miq-bot add_label gaprindashvili/backported This was released in manageiq-ui-components 1.0.4, backported to gaprindashvili via ManageIQ/manageiq-ui-classic#3175 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got changed back in #223, but it makes it so that when you try to edit anything other than drop down or radio button fields (the ones that use objects for their values), it attempts to call
.filteron a string and ends up blowing up silently in JS with you unable to edit your fields.@romanblanco @martinpovolny please review
@miq-bot add_label gaprindashvili/yes