Gtl module #24
Gtl module #24
Conversation
karelhala
force-pushed
the
gtl_module
branch
from
4ec6174
to
d8bffab
Compare
| */ | ||
| private static generateConfig(modelName?: string, activeTree?: string, currId?: string) { | ||
| let config = {params: {}}; | ||
| _.assign(config.params, DataTableService.generateModelConfig(modelName)); |
There was a problem hiding this comment.
We probably need to figure out the priority of libraries to use, when there is overlapping functionality. This statement is totally correct but should one use Object.assign(), _.assign(), [or even angular.merge, angular.extend].
Anyway, we probably need a standard approach to this so that each of of doesn't do it differently.
@himdel @martinpovolny wdyt?
There was a problem hiding this comment.
I'd go in the order of [ES6, lodash, angular, jquery], except for when the angular functions are explicitly needed because we want to skip stuff like $id etc. (And except for when you want to use a lodash feature not found in the es6 version)
There was a problem hiding this comment.
...but then again, that (es6 over lodash) assumes es6-shim or new browsers. We do that in miq, but not sure how far to take the library thing..
There was a problem hiding this comment.
I'd be more benevolent with this and put ES6 and lodash at the same level. But then egain, we are using Typescript and we no longer need to use _.map, _.each but use ES6's equivalents.
But if we agree on using more ES6 things over lodash's I'm ok with it.
There was a problem hiding this comment.
I'd be more benevolent with this and put ES6 and lodash at the same level.
No problem with that :). Either way, I guess there's no reason to change this PR..
|
@karelhala btw I'm glad the loader.ts has changed to index.ts seems much more standard. |
karelhala
force-pushed
the
gtl_module
branch
from
d8bffab
to
f51dd7b
Compare
|
New tests were added, so I think it's good to go. WDYT @himdel @martinpovolny @mtho11 |
karelhala
force-pushed
the
gtl_module
branch
from
2450a71
to
848c856
Compare
karelhala
force-pushed
the
gtl_module
branch
from
848c856
to
94da90b
Compare
Start of gtl module, this module will contain table, grid and list components.
This initial PR introduces services for these components (fetching data from URL) and adds this module to main module.