Update dynamic fields responders after change #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, blocker, gaprindashvili/yes |
|
/cc @d-m-u |
|
Thanks, @romanblanco !! 🎉 |
|
Checked commit romanblanco@3b7be84 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
reviewed
Sep 19, 2018
| @@ -42,6 +42,7 @@ <h4 class="modal-title" id="myModalLabel" translate>Edit Field Details</h4> | |||
| pf-label="{{'Dynamic'|translate}}"> | |||
| <input bs-switch | |||
| ng-model="vm.modalData.dynamic" | |||
| ng-change="vm.updateDialogFieldResponders(vm.modalData.name)" | |||
There was a problem hiding this comment.
Should we have a default implementation of vm.updateDialogFieldResponders?
Unconditionally calling an optional function sounds potentially bad...
EDIT: never mind, this is always defined
d-m-u
approved these changes
Sep 24, 2018
simaishi
pushed a commit
that referenced
this pull request
Sep 25, 2018
Update dynamic fields responders after change (cherry picked from commit f9c976b) https://bugzilla.redhat.com/show_bug.cgi?id=1632769
|
Gaprindashvili backport details: |
|
Released in 1.0.36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1614436
Removing field changed from dynamic to static from the list of responders for each associated field.
Steps to reproduce: