Disable toolbar dropdown if no item in the group is enabled. #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
Oct 31, 2018
| @@ -52,6 +52,12 @@ export class ToolbarListController implements IToolbarListBindings { | |||
| this.toolbarList.items && | |||
| this.toolbarList.items.filter((item: IToolbarItem) => !item.hidden).length > 0; | |||
| } | |||
|
|
|||
| private isToolbarEnabled(): boolean { | |||
| return this.toolbarList && | |||
There was a problem hiding this comment.
maybe add && this.toolbarList.enabled to move the whole condition here?
There was a problem hiding this comment.
Yup, that sounds better, plus use some so we don't have to iterate over the whole array.
private isToolbarEnabled(): boolean {
return this.toolbarList &&
this.toolbarList.enabled &&
this.toolbarList.items &&
this.toolbarList.items.some((item: IToolbarItem) => item.enabled)
}There was a problem hiding this comment.
Ok, I c-n-ped your method above. So fixing both methods to use some.
|
@miq-bot add_label blocker |
|
@himdel, @karelhala : please, re-review. Thx! |
|
Checked commits f224062~...1fbfd1d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM :) |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Disable toolbar dropdown if no item in the group is enabled. (cherry picked from commit af0d121) https://bugzilla.redhat.com/show_bug.cgi?id=1633727
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1633727