Dialog user - only run regex validation when validator_type is set to regex #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're saving `false` now in `validator_type` when validation is disabled, which gets serialized as `"f"` adding a spec that no regex validation is attempted unless `validator_type` is explicitly `regex` https://bugzilla.redhat.com/show_bug.cgi?id=1721814
|
Cc @eclarizio |
eclarizio
approved these changes
Jun 25, 2019
simaishi
pushed a commit
that referenced
this pull request
Jul 2, 2019
Dialog user - only run regex validation when validator_type is set to regex (cherry picked from commit 8d67e39) https://bugzilla.redhat.com/show_bug.cgi?id=1726438
|
Hammer backport details: |
This was referenced Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721814
The dialog-user component is only looking at
validator_rule, notvalidator_type.Thus, it attempts to run regex validation even when validation is disabled.
This is a follow-up to #388 which changed
validator_typefromundefinedtofalsewhen disabled.falsegets saved by automate as"f", which is not falsy.