Dialog User - set default value for tag controls #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now, field.default_value gets initialized to 0 for every DialogFieldTagControl. What should be happening: - single selects: <Choose>/<None> gets shown as default - multiselects: Nothing selected same as the other dropdowns and multidropdowns. Thus changing the initialization to set either "" or [] as default_value.
|
Checked commit https://github.com/himdel/ui-components/commit/2a74e2452ad80a64fdfd72655d8569fd84269896 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jan 9, 2020
|
(kicking stuck travis; the core dependency is merged now) |
This was referenced May 20, 2020
|
We need this in ivanchuk for https://bugzilla.redhat.com/show_bug.cgi?id=1859524 Although this will most likely require an ivanchuk-specific PR, since this probably won't cherry-pick cleanly. |
simaishi
pushed a commit
that referenced
this pull request
Jul 23, 2020
Dialog User - set default value for tag controls (cherry picked from commit a47b131) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1859524
|
Ivanchuk backport details: |
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now, field.default_value gets initialized to 0 for every DialogFieldTagControl.
What should be happening:
<Choose>/<None>gets shown as defaultNothing selectedsame as the other dropdowns and multidropdowns.
Thus changing the initialization to set either "" or [] as default_value.
Fixes ManageIQ/manageiq-ui-classic#6392
May depend on ManageIQ/manageiq#19696
and ManageIQ/manageiq#19697