[WIP] Dialog Editor - reset default_value when changing dropdown type, values, or between single and multiselect #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, or between single and multiselect Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746211
himdel
changed the title
|
Checked commits https://github.com/himdel/ui-components/compare/b283597888d38610c772907730f730fb261c79cb~...07c9a2fea47f19cf887a94964ff9ba93d27154c3 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing dropdown or tag control properties, changing the value type, single/multi, or the list of tags would not update the chosen defualt_value.
That leads to problems like integer multiselects having a default value of
1(integer), causing the backend code to blow up trying to iterate over the chosen options.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746211
wip - fixes the bug, but the reset method should be shared, and should pick the first value sometimes, (and maybe even preserve the original value if it still exists)
and move the watch part of entries change to oninit too
and check out the intent behind the relevant changes from #223
and convertValuesToArray should be merged into this code too