dialog-user: add flag for dialog reconfigure #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
May 25, 2020
| @@ -49,6 +50,7 @@ export class DialogFieldController { | |||
| public setup() { | |||
| this.clonedDialogField = _.cloneDeep(this.field); | |||
| this.dialogField = this.service.setupField(this.field); | |||
| this.dialogField.disabled = this.reconfigureMode && !this.dialogField.reconfigurable; | |||
There was a problem hiding this comment.
Can a field be disabled from automate?
I think this bit should only set disabled=true, but not overwrite with false if already present, if ^.
Otherwise LGTM :)
There was a problem hiding this comment.
Fixed (as discussed privately).
mzazrivec
force-pushed
the
add_support_for_dialog_reconfigure
branch
from
0bc9a0a
to
f23d891
Compare
|
Checked commit mzazrivec@f23d891 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Thanks, LGTM :) |
simaishi
pushed a commit
that referenced
this pull request
May 26, 2020
…gure dialog-user: add flag for dialog reconfigure (cherry picked from commit 5e79adf) https://bugzilla.redhat.com/show_bug.cgi?id=1837410
simaishi
pushed a commit
that referenced
this pull request
May 26, 2020
…gure dialog-user: add flag for dialog reconfigure (cherry picked from commit 5e79adf)
|
Jansa backport details: |
|
Ivanchuk backport details: |
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a dialog is being reconfigured, we need to honor the non-reconfigurable field flag and disable the respective input field.
@himdel
https://bugzilla.redhat.com/show_bug.cgi?id=1837410