Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiqVimVm#renameVM method #41

Merged
merged 1 commit into from Jul 2, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 2, 2018

end
message.add "n1:newName", newName
end
(parse_response(response, 'Rename_TaskResponse')['returnval'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare Shouldn't we be removing these parenthesis instead of adding new lines with them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

Add the ability to rename a VM from the MiqVimVm object.

https://bugzilla.redhat.com/show_bug.cgi?id=1559184
@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2018

Checked commit agrare@9efe51c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 11 offenses detected

lib/VMwareWebService/MiqVimVm.rb

lib/VMwareWebService/VimService.rb

@roliveri roliveri merged commit 58995ae into ManageIQ:master Jul 2, 2018
@agrare agrare deleted the add_miq_vim_vm_rename_vm branch July 2, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants