New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MiqVimVm#renameVM method #41
Conversation
lib/VMwareWebService/VimService.rb
Outdated
end | ||
message.add "n1:newName", newName | ||
end | ||
(parse_response(response, 'Rename_TaskResponse')['returnval']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare Shouldn't we be removing these parenthesis instead of adding new lines with them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
1223781
to
4f86cf1
Compare
Add the ability to rename a VM from the MiqVimVm object. https://bugzilla.redhat.com/show_bug.cgi?id=1559184
4f86cf1
to
9efe51c
Compare
Checked commit agrare@9efe51c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/VMwareWebService/MiqVimVm.rb
lib/VMwareWebService/VimService.rb
|
Add the ability to rename a VM from the MiqVimVm object.
VIM SDK definition: https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/vim.ManagedEntity.html#rename
https://bugzilla.redhat.com/show_bug.cgi?id=1559184