Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Recognition #169

Closed
Valdnet opened this issue Jan 10, 2022 · 38 comments
Closed

Text Recognition #169

Valdnet opened this issue Jan 10, 2022 · 38 comments
Labels
bug Something isn't working
Milestone

Comments

@Valdnet
Copy link
Collaborator

Valdnet commented Jan 10, 2022

Steps:

  1. Turn off data transfer.
  2. Tap on the camera icon.
  3. Select "Install".
  4. Go to settings.
  5. Select "Text Recognition".

Information about the downloaded language is displayed even though it was not installed:

obraz

@Valdnet Valdnet added the bug Something isn't working label Jan 10, 2022
@Valdnet Valdnet added this to the v1.1.4 milestone Jan 10, 2022
@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 10, 2022

When downloading all languages, the languages that have already been downloaded are downloaded again (the download progress wheel informs you about it):

obraz
obraz

@ManeraKai
Copy link
Owner

Should I keep the download all feature. It really is just for someone that wants to play. No one will use it IRL. I'm saying that because the download all is a little bit complicated.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 10, 2022

It must be clear to the user what he has downloaded and what else he can download despite whether or not this feature will be used frequently. If we already add such an option, it must work properly 😉.

@ManeraKai
Copy link
Owner

ManeraKai commented Jan 10, 2022

I just meant the Install all button.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 10, 2022

I just meant the Install all button.

OK. The button itself tells the user that it is installing everything.

@ManeraKai
Copy link
Owner

OK, I will fix it.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 11, 2022

OK, I will fix it.

I don't know if you got me right. The "Install all" problem may stay that way. The user choosing to install everything is aware that he is installing all languages. And whether it re-installs them, or just the ones that are already installed, it doesn't really matter. The user only wastes a little time downloading.

But the problem described in the first post should be corrected.

ManeraKai added a commit that referenced this issue Jan 15, 2022
@ManeraKai
Copy link
Owner

Still maturing it but I think the problem is fixed: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1701929155

@ManeraKai
Copy link
Owner

I may deleted install all for now. Don't worry, I will added it

@ManeraKai
Copy link
Owner

Or should I? I'm really not seeing a purpose from it.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 16, 2022

Steps:

  1. Select the camera icon.
  2. Select the "Install" button.

While installing "Text Recognition", I cannot see the download progress bar as it was before:

obraz

@Valdnet Valdnet mentioned this issue Jan 16, 2022
@ManeraKai
Copy link
Owner

I think it works in this one: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1704801468

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 16, 2022

Steps:

  1. Select the camera icon.
  2. Select "Install".
  3. Select "Cancel".
  4. Go to the application settings.
  5. Select "Text Recognition".

The download completes even though the installation is canceled.

@ManeraKai
Copy link
Owner

Fixed: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1705212904

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 17, 2022

I. Steps:

  1. Select "Settings".
  2. Select "Text Recognition".
  3. Tap on any language to install.

During the language installation, the button (installation progress) is still active and you can tap continuously, which causes the language installation process to be repeated.

II. Steps:

  1. Tap the camera icon.
  2. Select "Install".
  3. Tap next to the loading progress window.
  4. Tap the camera icon again.

The "Text Recognition" installation process is not finished yet and the application allows you to start the camera.

ManeraKai added a commit that referenced this issue Jan 17, 2022
@ManeraKai
Copy link
Owner

Fixed: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1708623672

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 17, 2022

Steps:

  1. Tap the camera icon.
  2. Select "Install".
  3. Once installed, go to the "Text Recognition".

The icon for the installed language does not change.

@ManeraKai
Copy link
Owner

Isn't this the same as the first bug?

ManeraKai added a commit that referenced this issue Jan 17, 2022
@ManeraKai
Copy link
Owner

ManeraKai commented Jan 17, 2022

np: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1709182922

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 18, 2022

Can these error messages be added to the translation so that they are meaningfully understood by the user?

obraz
obraz

These are error messages from the ready plug-in and are taken from Android.

@ManeraKai
Copy link
Owner

The second one should is too technical I think. The first one I'll search for it.

@ManeraKai
Copy link
Owner

image
Here are they. Apparently they're untranslatable, but I can add something like if (camera.isGranted())

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 18, 2022

Here are they. Apparently they're untranslatable, but I can add something like if (camera.isGranted())

Good idea 👍. This will resolve unreadable error messages 😉.

@ManeraKai
Copy link
Owner

Did that: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1715274831

@Valdnet Valdnet closed this as completed Jan 19, 2022
@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 19, 2022

Steps:

  1. Run "Text Recognition".
  2. Turn the smartphone over to a horizontal position.
  3. Take a picture of the text.
  4. Place the smartphone vertically.

Sometimes the application window does not return to a vertical position. The application stops after a long time.

obraz

@Valdnet Valdnet reopened this Jan 19, 2022
@Aga-C
Copy link
Contributor

Aga-C commented Jan 19, 2022

Translation is blocked on Weblate ("main" component).

@ManeraKai
Copy link
Owner

@Aga-C it got some conflicts because I added a new string. Will fix it.

@ManeraKai
Copy link
Owner

ManeraKai commented Jan 19, 2022

Translation is blocked on Weblate ("main" component).

@Aga-C Fixed it... Hopefully.

ManeraKai added a commit that referenced this issue Jan 19, 2022
@ManeraKai
Copy link
Owner

@Valdnet Fixed it too: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1718532979

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 20, 2022

Steps:

  1. Run "Text Recognition".
  2. Turn the smartphone over to a horizontal position.
  3. Take a picture of the text.
  4. Place the smartphone vertically.
  5. Turn the smartphone over horizontally again.

Sometimes the application window does not span the entire screen:

obraz

@ManeraKai
Copy link
Owner

I think this has something to do with skipping frames due to overload on the main thread. I will begin optimizing the tesseract_ocr in the next release. What do you think @Valdnet?

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 21, 2022

It also seems to me that this is a performance issue (this may be because it is in debug mode). So the tests are complete. A new version can be released 😉.

Issue to close?

@ManeraKai
Copy link
Owner

No, keep it open as we'll complete improving it unless you want to open a dedicated issue for performance thingies.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Jan 21, 2022

We will leave him open to possible issues 😉.

@Valdnet Valdnet modified the milestones: v1.1.4, v1.1.5 Jan 21, 2022
@tswistak
Copy link

tswistak commented Feb 17, 2022

Unfortunately, for me, it doesn't work. When I take a photo, loader appears and then apps hangs (there is this Android window that app is not responding). Even if I click "Wait", app crashes after a while.

My phone: OnePlus 8 Pro with Android 11.

@Aga-C
Copy link
Contributor

Aga-C commented Feb 17, 2022

The text recognition usually works very slow and can hang a bit. After recognition, it sometimes selects some noise what causes displaying strange characters during translation - it seems that it depends on the sharpness of the text and surface.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Feb 17, 2022

When I take a photo, loader appears and then apps hangs (there is this Android window that app is not responding).

I had such frequent crashes on the debug version.

@ManeraKai
Copy link
Owner

This needs optimization and some improvements on text recognition.

@Valdnet Valdnet modified the milestones: v1.2.1, v1.2.2 Apr 28, 2022
@Valdnet Valdnet modified the milestones: v1.3.1, v1.3.2 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants