New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Text-To-Speech Functionality #88
Comments
Added a pause button: d00c5f5 |
@ManeraKai @metalune1 Why the sample text below cannot be read by the "SimplyTranslate" translator and therefore the mobile application cannot read the translation?
Google Translator reads correctly. |
It has to do with the length of the message. Cut it a little bit and it will work. |
Yeah I've noticed and changed this before 2 minutes. |
Enabled the stop button all the time even if there is not text too. |
Here is a link that requests long text to be TTS'ed from google translate directly: https://translate.google.com/translate_tts?tl=en&client=tw-ob&q=Lorem%20ipsum%20dolor%20sit%20amet%20consectetur%20adipiscing%20elit%20Cras%20sodales%20finibus%20congue%20Morbi%20facilisis%20non%20neque%20sed%20pharetra.%20Nulla%20faucibus%20posuere%20risus.%20Sed%20sed%20condimentum%20massa.%20Ut%20mattis%20finibus%20elit%20vel%20aliquet.%20Nunc%20purus%20velit,%20sagittis%20bibendum%20felis%20pulvinar,%20ornare%20hendrerit%20metus.%20Sed%20laoreet%20eu%20lectus%20ac%20accumsan.%20Phasellus%20in%20fringilla%20nulla.%20Nulla%20eu%20mauris%20euismod,%20rutrum%20massa%20vel,%20eleifend%20nunc.%20Aenean%20ut%20rutrum%20leo,%20id%20vulputate%20libero. |
Exactly. It has to do with the fact that the application allows for translation 😉.
Not good. It should translate longer sentences 😬. If there is a restriction by Google Translator then user should be informed when reading that the sentence is too long or change the "Speaker" icon to gray (inactive) because it looks like the application has a bug. |
If this is an unknown error, inform the user of the application when reading it, or:
|
I'll try first to TTS the long text first (Reverse engineering). If it doesn't work, we'll notify the user about it. |
Nope. I'll notify the user to read it by himself. |
Added a notification when the user tries to click the disabled |
Change
|
Translation made in PR: #119. |
I noticed that the instance in the application settings is now set to "Random". As a result, if the application uses the The user is confused that TTS is working correctly once (if using I suggest:
If there are no plans to implement TTS in the To set the default instance of
To set the default instance to "Random":
Currently, it only gets the message "Something went wrong". And it would be best to implement TTS quickly on the server for |
I've contacted alefvanoon about that. Official instances should be up-to-date imo, but having a more detailed error message for any custom instance is good though. |
Cool 👍.
Remember about this change. |
Waiting for his response. The random option only includes official instances. |
Ok 😉. Can you add a new text string for translation? Is |
Sorry |
Yeah because the instance selection is random. I've sent an email to @alefvanoon on Thursday, and a message on Matrix this day. and I'm waiting for his response. We'll try to add a skip logic if he didn't respond in those 2 coming days. |
But the error is because if you quickly tap the "Speaker" icon several times. In my opinion, it should be blocked from tapping the "Speaker" icon until the message appears. Normally if TTS is running it is possible to stop speech. In the absence of TTS support by the instances, it is possible to tap several times, which causes the message to appear several times. See the application screen is black, caused by the pop-up of multiple message boxes. |
Oh sorry, I misunderstood 👍 |
This solution will be temporary until we get tts support info end point from the server-side: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1324175441 |
You did the TTS block very nicely 👍. The next error is: Steps:
You hear the TTS of one text. Then TTS starts from the second window. The icons do not change back to "Speaker". |
Testing successful 👍. |
Problem now is if the http request took a long time, you don't have a cancel button. |
Sorry for being late. My instance was updated. |
Great! Thanks! |
I think by natural the user will try to click on the loading circle to cancel it. I'm making the loading circle clickable and it's function is to cancel the request. |
Added that: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1325424181 |
Now TTS works fine 🥇. |
So, this issue will be closed and the end-point's tts support page feature will be opened in another issue for milestone |
Why not release TTS in app version 1.1.2? |
It is in |
Hmmm. As for me, the application works fine with TTS, but the decision remains for the developers 😁. |
That decision will be for the Simple Web team. If they created that page. We'll support it, and vise versa 👍 |
Hi, as of today SimplyTranslate supports Google TTS, (you can see it here: https://simplytranslate.org) and I would love for this to be implemented in this app as well. There is an api endpoint at /api/tts?engine={engine}&lang={lang}&text={text}
The text was updated successfully, but these errors were encountered: