Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bevy 0.12 #21

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Upgrade to Bevy 0.12 #21

merged 4 commits into from
Nov 11, 2023

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Nov 10, 2023

Updates dependencies to support Bevy 0.12 and replaces the depracated iter method to read for event readers. A really easy migration :)

@Jondolf Jondolf mentioned this pull request Nov 10, 2023
Merged
@Jondolf
Copy link
Contributor Author

Jondolf commented Nov 10, 2023

Fixed the lint errors, some documentation was still using .add_plugin(...) which was depracated in 0.11 already and removed in 0.12

ManevilleF
ManevilleF approved these changes Nov 10, 2023
View reviewed changes
Copy link
Owner

@ManevilleF ManevilleF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you are missing a CHANGELOG entry

@Jondolf
Copy link
Contributor Author

Jondolf commented Nov 10, 2023

Added dependency versioning updates to changelog

@ManevilleF ManevilleF merged commit d1820b1 into ManevilleF:main Nov 11, 2023
7 checks passed
@Jondolf Jondolf deleted the bevy-0.12 branch November 11, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManevilleF ManevilleF ManevilleF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jondolf @ManevilleF