-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh builder #80
Mesh builder #80
Conversation
@alice-i-cecile what do you think of the builder API ? Also, I wonder if I should remove the cheap column I doubt anyone is using it |
Builder API is nice, although I'd probably make the fields |
@alice-i-cecile all done, could you check that this PR doesn't break anything in emergence ? Also you might be able to remove the bottom face now and save a few triangles |
Yeah, lemme try out a migration :) |
Experiments:
Mesh merging with its current API is not very useful at all:
IMO cut mesh merging from this PR and release. |
The mesh merging method was mostly created for inner usage, it is used by the |
I added comments to your test attempt, I think you are missing a single param for merging to work as expected. About the |
Agreed on the chunking point: I wanted to test it out quick and see how it works :) |
Work done
MeshInfo
struct can be merged with other meshes (@alice-i-cecile )ColumnMeshBuilder
for column meshesPlaneMeshBuilder
for plane meshesmesh_builder
example showcasing builder options