Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Skill Checks are not triggering Dice So Nice and/or dice sound #18

Closed
rtakehara opened this issue Sep 7, 2022 · 7 comments · Fixed by #23 or #26
Closed

[BUG] Skill Checks are not triggering Dice So Nice and/or dice sound #18

rtakehara opened this issue Sep 7, 2022 · 7 comments · Fixed by #23 or #26
Assignees
Labels
bug Something isn't working

Comments

@rtakehara
Copy link

Description
The module doen't appear to be triggering Dice So Nice when rolling Skill Checks, Saving Throws and Attack Rolls, Damages and other rolls work fine.

I also tried using just RSR with no other modules, and dice rolls don't reproduce any sound.

Steps to Reproduce

  1. Roll any skill check

Versions

  • Module: [1.0.2]
  • dnd5e: [2.0.2]
  • Foundry: [10.284]

Other Modules
Dice So Nice, but I also tried with nothing and there is no dice roll sound.

@rtakehara rtakehara added the bug Something isn't working label Sep 7, 2022
@KumoGekkou
Copy link

More specifically, with Dice so Nice, it does not roll any d20s. Since skill checks are only d20's it's most obvious, but when using attack's, only the damage dice are rolled through Dice so Nice, not the d20s.

@MangoFVTT
Copy link
Owner

Support for other modules is not yet something I've spent much time on. I will be focusing on getting the module itself to a stable state and hopefully achieving feature parity with Better Rolls first, before moving on to fixing compatibility issues. If I had to guess, it's likely because Dice so Nice and this module both hook into dice rolling functions and might be interfering with each other.

Dice Sounds are on the docket and will be worked on in a future release

@MangoFVTT MangoFVTT linked a pull request Sep 7, 2022 that will close this issue
@KumoGekkou
Copy link

Support for other modules is not yet something I've spent much time on. I will be focusing on getting the module itself to a stable state and hopefully achieving feature parity with Better Rolls first, before moving on to fixing compatibility issues. If I had to guess, it's likely because Dice so Nice and this module both hook into dice rolling functions and might be interfering with each other.

Dice Sounds are on the docket and will be worked on in a future release

Yes, thank you. I should have started with thanking you for building this at all. I was devastated to learn better rolls was abandoned and truly appreciate your work!

@MangoFVTT
Copy link
Owner

You're very welcome! Just so you know, Dice roll sounds are being added in the 1.1.0 release, which shouldn't be too far out.

@MangoFVTT
Copy link
Owner

Closing this as Dice Sounds are now released. Dice So Nice functionality will happen at a later date.

@KumoGekkou
Copy link

Just a note, the Dice so Nice is working, just not D20 rolls. All other rolls that use both are working as intended.

@MangoFVTT MangoFVTT linked a pull request Sep 7, 2022 that will close this issue
@MangoFVTT
Copy link
Owner

@KumoGekkou @rtakehara Dice So Nice compatibility is now fixed with Release 1.2.0 and D20 rolls should roll 3D dice correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants