Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/d20-rolls-not-in-chat-message #26

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

MangoFVTT
Copy link
Owner

Includes D20 dice into the chat message data so that modules that pick up on it to do other things (e.g. Dice So Nice) can use it appropriately. Did some trickery here to ensure that D20 values that aren't damage aren't actually added to the "total damage" value when using apply damage context menu.

Closes #18.

@MangoFVTT MangoFVTT added the bug Something isn't working label Sep 7, 2022
@MangoFVTT MangoFVTT self-assigned this Sep 7, 2022
@MangoFVTT MangoFVTT linked an issue Sep 7, 2022 that may be closed by this pull request
@MangoFVTT MangoFVTT merged commit 4e36fcc into develop Sep 7, 2022
@MangoFVTT MangoFVTT deleted the bugfix/d20-rolls-not-in-chat-message branch September 7, 2022 20:46
@MangoFVTT MangoFVTT linked an issue Sep 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Integrate with Dice So Nice [BUG] Skill Checks are not triggering Dice So Nice and/or dice sound
1 participant