Change the parameter type from int to string in ApiUsers.php function… #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GetBankAccount Since Mangopay has changed the format of Ids, bank account ids have also changed. As a result, now the ids are string instead of integers. My change proposes a change in $bankAccountId parameter data type from int to string on Line 148. The reason from proposing this change is that for me, my project was failing phpsalm and phpstan checks
mralaminahamed
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… GetBankAccount
Since Mangopay has changed the format of Ids, bank account ids have also changed. As a result, now the ids are string instead of integers. My change proposes a change in $bankAccountId parameter data type from int to string on Line 148. The reason from proposing this change is that for me, my project was failing phpsalm and phpstan checks