-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remove_slow.py. Fixes #36 #37
Conversation
Test-merge to see if versions work
Added BETA support for Readarr && removed 'Unknown Manifest' Problem (which removes ARM + x86 support) -> PRs to fix it apprecaited
Readme update #patch
Slow downloads check will only run with torrent type entries. Usenet entries will be skipped.
Just a quick thought: you could also fix this globally by implementing the check in the get_queue() function under shared.py. However i will leave it up to you on which level you would want to skip usenet based downloads. |
Thought: To Then the slow check would still work for all doenload types but only torrents would be checked against qbit (snd only if thats the torrent client) else vs arr-queue status directly (which is less frequently updated) (Untested- just pseudocode written from my phone 😄) |
Yes this seems to work as well! I'll modify my request. [DEBUG]: getDownloadedSize/WARN: Using imprecise method to determine download increments because no direct qBIT query is possible |
Moved qBittorrent / torrent check from remove_slow() function to getDownloadedSize()
Just updated the code, validated on my own setup, moved the check to the getDownloadedSize() function and seems to work! |
hi, I changed the target branch to "dev", so we can build it there first. Above says there are conflicts, and I don't seem able to resolve it (guess cause the branch is in your git profile) -> can you please have a look? once resolved, will merge to dev and then you can pull & test |
The conflict is because you previously placed the content of the function getDownloadedSize inside of a try / except block. I forked main which does not have this change. You can either approve the merge and get rid of the try / except block (like it is in main as well) or i can add the try / except block to my code. My preference would be to go for the first option since we eventually want to merge this to main which does not have a try / except block (was placed there for troubleshooting.) |
Pls add it as in dev so in case of future probs it works and we can try the dev image |
Added try / except block in function getDownloadedSize()
Added NAME variable to function.
Removed redundant space
Seems good to me now. No idea why the return statement is acting funny but its the exact same. |
Mh. Still can’t merge…Do you want to simply quickly fork from dev; copy the new code snd create another pr back to dev snd close this one? |
Slow downloads check will only run with torrent type entries. Usenet entries will be skipped.