Fix PointData::setIndexOfVariant accidentally doing pass-by-value
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first parameter of the private member function `PointData::setIndexOfVariant` should be passed by reference. Before this commit, it did pass-by-value, causing calls to `PointData::setElementTypeSpecifier` to have no effect at all. The bug was introduced with pull request #454 commit 55f50a9 "Replace private `PointData::VectorHolder` class with `std::variant` (merged on 5 February 2024) and reported to me by Jeroen Eggermont.
ThomasKroes
deleted the
feature/PointData-setIndexOfVariant-pass-by-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first parameter of the private member function
PointData::setIndexOfVariantshould be passed by reference. Before this commit, it did pass-by-value, causing calls toPointData::setElementTypeSpecifierto have no effect at all.The bug was introduced with pull request #454 commit 55f50a9 "Replace private
PointData::VectorHolderclass withstd::variant(merged on 5 February 2024) and reported to me by Jeroen Eggermont (@jeggermont).