Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StatisticManager.php #218

Merged
merged 2 commits into from Apr 27, 2019
Merged

Update StatisticManager.php #218

merged 2 commits into from Apr 27, 2019

Conversation

jonthekiller
Copy link
Contributor

Fix warning PHP 7.3
#216

Fix warning PHP 7.3
@steeffeen
Copy link

Hi, you seem to have replaced all continue statements even though only the ones in switch statements should be replaced. There are quite some continue statements in foreach loops which should probably stay, no?

Rollback change inside foreach
@jonthekiller
Copy link
Contributor Author

You are right, I have rollback this part.

@kremsy
Copy link
Member

kremsy commented Apr 27, 2019

maybe the if(!...) should be reversed that the code below gets carried out within the IF so the break is not needed anymore.

Copy link
Member

@kremsy kremsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a solution, but bette rwould be to change the

if(!a || !b) {
break;
}
somecode
break;

to

if(a && b) {
somecode
}

break;

to avoid multiple breaks

Please edit this if possible and do a new Pull request

@kremsy kremsy merged commit 3a10908 into ManiaControl:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants