feat(gridster): enable resize of gridster container #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the resizing of the container for the gridster. Previously, the directive used to listen to the windows `resize` event only. Fix for the generic resize event. New width/height values are now kept separately from the actual width/height config, that can be a string (auto or match). Add test methods for the new resize parameters. Implement a protractor test to check for the test behavior. Generate dist files. Update `index.html` to reflect new changes. Update `README.md` with import information. Add .idea folder to gitignore files. Close ManifestWebDesign#52.
|
The Travis build is failing with this message: The command "./node_modules/protractor/bin/install_selenium_standalone" failed and exited with 127 during before_script. Can you confirm the node dependencies are properly configured? |
|
After reviewing your commit, I don't think that build error is related. Merging now. Thanks for doing this! |
danomatic
added a commit
that referenced
this pull request
May 8, 2014
feat(gridster): enable resize of gridster container
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the resizing of the container for the gridster. Previously, the directive used to listen to the windows
resizeevent only.Fix for the generic resize event. New width/height values are now kept separately from the actual width/height config, that can be a string (auto or match).
Add test methods for the new resize parameters.
Implement a protractor test to check for the test behavior.
Generate dist files.
Update
index.htmlto reflect new changes.Update
README.mdwith import information.Add .idea folder to gitignore files.
Close #52.